New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log warning when tracing not enabled #395

Merged

danielcompton merged 1 commit into day8:develop from saskali:warning-on-tracing-not-set

Aug 14, 2017

Contributor

saskali commented Aug 9, 2017

problem: when people want to use tracing and forget to set closure-defines, traces don't show up and no errors or warnings are being displayed
solution: check if tracing is enabled. if not, log warning message when opening trace panel
fixes Log a warning when user tries to add a trace callback but hasn't set a closure-define #384


          Log warning when tracing not enabled

7dcbb96

danielcompton self-assigned this

danielcompton self-requested a review

August 14, 2017 08:29

danielcompton approved these changes

View reviewed changes

danielcompton merged commit c43192f into day8:develop

Contributor

danielcompton commented Aug 14, 2017

Great stuff!

danielcompton added a commit that referenced this pull request


          Update changelog to include #395

ed300cf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet